Spinlock #36030
Merged
Spinlock #36030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Comment on lines
73
to
105
| static inline void CpuRelax() { | ||
| #if defined(__WQ_x86__) | ||
| _mm_pause(); | ||
| #endif | ||
| } | ||
|
|
||
| class SpinLock { | ||
| public: | ||
| void lock() { | ||
| for (;;) { | ||
| if (!lock_.exchange(true, std::memory_order_acquire)) { | ||
| break; | ||
| } | ||
| constexpr int kMaxLoop = 32; | ||
| for (int loop = 1; lock_.load(std::memory_order_relaxed);) { | ||
| if (loop <= kMaxLoop) { | ||
| for (int i = 1; i <= loop; ++i) { | ||
| CpuRelax(); | ||
| } | ||
| loop *= 2; | ||
| } else { | ||
| std::this_thread::yield(); | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| void unlock() { lock_.store(false, std::memory_order_release); } | ||
|
|
||
| private: | ||
| std::atomic<bool> lock_{false}; | ||
| }; | ||
|
|
There was a problem hiding this comment.
如果测试发现，你这个版本的SpinLock更好，最好是去修改我之前写的SpinLock，而不是再写一个新的。Paddle里有1个SpinLock即可。
Aurelius84
approved these changes
Sep 26, 2021
标题已完善，在PTB模型训练场景下不会有效果，因为竞争不够激烈，没有触发worker休眠。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Performance optimization
PR changes
Others
Describe
1）更新SpinLock实现
2）RunQueue使用spinlock替换mutex。防止竞争激烈时，worker线程休眠。