Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Xbyak to v5.81 #30809

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Update Xbyak to v5.81 #30809

merged 1 commit into from
Feb 2, 2021

Conversation

wozna
Copy link
Contributor

@wozna wozna commented Feb 1, 2021

PR types

Others

PR changes

Others

Describe

This PR updates the Xbyak from 5.661 to 5.81. Only from this version, the instructions related to BF16 are correctly checked.
This PR is one part of the assignment to add BF16 instruction checks.
Moreover, because I've changed Xbyak library version from v5.661 to v5.81 it turned out that one of the functions has changed from void L (const Label & label) to void L (Label & label), so we also have to remove const from jitcode.h so that there is no error.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Feb 1, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wozna
Copy link
Contributor Author

wozna commented Feb 1, 2021

@luotao1 Could you start your review?

@luotao1 luotao1 merged commit 04532b8 into PaddlePaddle:develop Feb 2, 2021
@wozna wozna deleted the update_xbyak branch February 24, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants