Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add beam search doc #11469

Merged
merged 8 commits into from
Jun 20, 2018
Merged

add beam search doc #11469

merged 8 commits into from
Jun 20, 2018

Conversation

Superjomn
Copy link
Contributor

No description provided.

@reyoung
Copy link
Collaborator

reyoung commented Jun 15, 2018

default

default

default

default

default

default

@@ -1719,7 +1719,7 @@ def inputs(layers, *args):
if len(args) != 0:
layers.extend(args)

Inputs(*[l.name for l in layers])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这两行最好不要动


ConditionalBlock is an operator that bind a block to a specific condition,
if the condition matches, the corresponding block will be executed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以加一下初始化参数列表Args:

Copy link
Contributor Author

@Superjomn Superjomn Jun 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是个 class, args是加 __init__ 里的参数列表?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Superjomn
Copy link
Contributor Author

image

image

image

image

Copy link
Member

@jacquesqiao jacquesqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Superjomn Superjomn merged commit d020d7f into PaddlePaddle:develop Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants