-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shell scripts in prepare_weights don't work without modification #23
Comments
A CI server will catch all of these kinds of things. The easiest way to avoid a CI server is to use a docker container, and just make sure the commands all run and you can launch some test script. |
Thanks for your interest. Is the problem solved now? We currently don’t have the manpower to package it into docker. This step will be completed in the future. |
I can resolve it, but I am pointing out the scripts are failing as currently designed. I can provide a gist with a fix or a pull request if your team will take contributions. Several other members of my team are planning to use the project but I need to make it possible to set up and install. |
ok, please submit a PR |
Will work on this tonight. |
thanks |
Related to #23, shell scripts should run successfully w/o modification
Probably there is a difference in the current developer "internal" build vs what got released to OSS. The issues are identified below with solution:
The text was updated successfully, but these errors were encountered: