Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(benchmarks): upload benchmark results for environments #48

Merged
merged 4 commits into from
Apr 26, 2023

Conversation

muchvo
Copy link
Collaborator

@muchvo muchvo commented Apr 25, 2023

Description

  1. Upload benchmark results for environments.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

@muchvo
Copy link
Collaborator Author

muchvo commented Apr 25, 2023

@liuzuxin Add benchmark results.

Copy link
Member

@Gaiejj Gaiejj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice Pull Request. The following suggestions may make it better:

  • Add a link of Safety-Gym in your benchmark README file, like: Safety Gym
  • Provide a 1e7 version of velocity benchmarks. Because the SafetyHumanoidVelocity-v1 make little sense in 1e6 setting.

@muchvo
Copy link
Collaborator Author

muchvo commented Apr 25, 2023

A nice Pull Request. The following suggestions may make it better:

  • Add a link of Safety-Gym in your benchmark README file, like: Safety Gym
  • Provide a 1e7 version of velocity benchmarks. Because the SafetyHumanoidVelocity-v1 make little sense in 1e6 setting.
  1. Solved.
  2. 1e7 and 1e6 are both in this PR with the first commit.

Gaiejj
Gaiejj previously approved these changes Apr 25, 2023
Copy link
Member

@Gaiejj Gaiejj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@Gaiejj Gaiejj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@zmsn-2077 zmsn-2077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@muchvo muchvo merged commit 2e3c510 into PKU-Alignment:main Apr 26, 2023
@muchvo muchvo deleted the benchmarks branch April 26, 2023 00:49
@muchvo muchvo linked an issue Apr 26, 2023 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] Any benchmark results available for the set of tasks?
3 participants