Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Gymnasium conversion wrappers #46

Merged
merged 25 commits into from
Apr 19, 2023

Conversation

XuehaiPan
Copy link
Member

@XuehaiPan XuehaiPan commented Apr 18, 2023

Description

Describe your changes in detail.

Add Gymnasium conversion wrappers. They convert the Safety-Gymnasium environment to the standard Gymnasium API and vice versa.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Resolves #43

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

@XuehaiPan XuehaiPan self-assigned this Apr 18, 2023
@XuehaiPan XuehaiPan added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 18, 2023
@XuehaiPan XuehaiPan added this to the 0.3.0 milestone Apr 18, 2023
zmsn-2077
zmsn-2077 previously approved these changes Apr 18, 2023
Copy link
Member

@zmsn-2077 zmsn-2077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuehaiPan XuehaiPan changed the title feat: add Gymnasium conversation wrappers feat: add Gymnasium conversion wrappers Apr 18, 2023
Gaiejj
Gaiejj previously approved these changes Apr 18, 2023
Copy link
Member

@Gaiejj Gaiejj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

zmsn-2077
zmsn-2077 previously approved these changes Apr 18, 2023
Copy link
Member

@zmsn-2077 zmsn-2077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@XuehaiPan XuehaiPan requested a review from muchvo April 18, 2023 12:27
@muchvo muchvo dismissed stale reviews from zmsn-2077 and Gaiejj via 8dc8534 April 18, 2023 12:45
Copy link
Member

@zmsn-2077 zmsn-2077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zmsn-2077 zmsn-2077 self-requested a review April 18, 2023 14:42
Copy link
Member

@Gaiejj Gaiejj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@muchvo muchvo merged commit b28acfb into PKU-Alignment:main Apr 19, 2023
@XuehaiPan XuehaiPan deleted the gymnasium-conversation branch April 19, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Adding support for standard gymnasium API by removing the cost from the return variables
4 participants