Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make environment copyable including current state #103

Merged
merged 5 commits into from
May 14, 2024

Conversation

BeFranke
Copy link
Contributor

Description

Adds a __deepcopy__ Method to builder.py, making it possible to clone an environment including its current state by simply deepcopy(env)

Motivation and Context

For some use cases, backing up the current state or branching off is desireable.
closes #95

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required) <- make format crashes on my end, help would be appreciated
  • I have checked the code using make lint. (required) <- reformatting not possible, see above. I did my best to sort imports and fix linting errors manually.
  • I have ensured make test pass. (required)

@muchvo muchvo changed the title Make Environemnt Copyable Including Current State fix: make environment copyable including current state May 14, 2024
Gaiejj
Gaiejj previously approved these changes May 14, 2024
Copy link
Member

@Gaiejj Gaiejj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@BeFranke BeFranke dismissed Gaiejj’s stale review May 14, 2024 09:09

The merge-base changed after approval.

@muchvo muchvo closed this May 14, 2024
@muchvo muchvo reopened this May 14, 2024
Copy link
Member

@Gaiejj Gaiejj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@muchvo muchvo merged commit 2f56afe into PKU-Alignment:main May 14, 2024
8 checks passed
@muchvo
Copy link
Collaborator

muchvo commented May 14, 2024

Thank you for your contribution. The code has been merged into the main branch.

@muchvo muchvo linked an issue May 15, 2024 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] Duplicating an environment including its current state
3 participants