Skip to content

Commit

Permalink
Merge pull request #73 from Ouranosinc/nbval-default-ignore-html-and-…
Browse files Browse the repository at this point in the history
…javascript-output

Nbval default ignore html and javascript output

# Overview

Ignore by default html and javascript output to decrease usage of `NBVAL_IGNORE_OUTPUT`.

## Changes

- Adds `conftest.py` following https://nbval.readthedocs.io/en/latest/index.html?highlight=skip#Skipping-certain-output-types

## Related Issue / Discussion

- Probably will avoid us needing `--nbval-lax`.
- Tested with Raven notebooks http://jenkins.ouranos.ca/job/PAVICS-e2e-workflow-tests/job/nbval-default-ignore-html-and-javascript-output/2/console all diff from xarray html output are gone

## Additional Information

Nbval documentation was not 100% correct: computationalmodelling/nbval#168
  • Loading branch information
tlvu authored May 19, 2021
2 parents 8f8fc30 + e31a2a1 commit 7a498c1
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions conftest.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
def pytest_collectstart(collector):
if collector.fspath and collector.fspath.ext == '.ipynb':
collector.skip_compare += 'text/html', 'application/javascript',

0 comments on commit 7a498c1

Please sign in to comment.