Translate message "Nothing to show" #319
Conversation
# Conflicts: # packages/client-react/src/translations.js
abaliunov-sc
changed the title
| @@ -39,6 +43,7 @@ const translations = { | |||
| }; | |||
|
|
|||
| export default function getMessage(locale, key, params) { | |||
| console.log(locale, key, params); | |||
There was a problem hiding this comment.
I'm not sure that we need to log it for every function call. Maybe remove it?
| @@ -2,10 +2,14 @@ const translations = { | |||
| en: { | |||
| 'common.Toolbar.moveForward': 'Move forward', | |||
| 'common.Toolbar.moveBack': 'Move back', | |||
| 'nothingToShow': 'Nothing to show', | |||
There was a problem hiding this comment.
Please, rename the key to 'common.NoFilesFoundStub.title' according to convention in the issue https://opuscapita.atlassian.net/browse/EPROC-20549
| @@ -2,10 +2,14 @@ const translations = { | |||
| en: { | |||
| 'common.Toolbar.moveForward': 'Move forward', | |||
| 'common.Toolbar.moveBack': 'Move back', | |||
| 'nothingToShow': 'Nothing to show', | |||
| 'useContextMenu': 'Use toolbar or context menu to perform available actions' | |||
There was a problem hiding this comment.
Please, rename the key to 'common.NoFilesFoundStub.message' according to convention in the issue https://opuscapita.atlassian.net/browse/EPROC-20549
There was a problem hiding this comment.
LGTM
Consider adding translations for other languages too https://github.com/OpusCapita/filemanager/blob/4c6ea274d199a3e15d163ce1bb86fb5bf3146631/packages/client-react/src/translations.js or rename this PR to Translate message "Nothing to show" into French
|
Translated into Fr, De, Ru. Messages in other languages will be added by @amotuz-sc later. |
#305