-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to call own methods on resource item events #210
Conversation
@jakubszewczyk, thanks for PR! Please add new properties to FileNavigator documentation. Please create an issue (you can partially copy-paste PR description) and refer to this PR. |
@kvolkovich-sc Done 🙂 |
@jakubszewczyk, thanks. I'll merge and release it a little later. |
I'm glad. Keep up the good work! |
You can avoid |
Client React API changes ===== FileNavigator component now support these callback props: - onResourceItemClick - onResourceItemDoubleClick - onResourceItemRightClick Co-authored-by: jakubszewczyk <jakub.szewczykk@gmail.com> Co-authored-by: kvolkovich-sc <kirill.volkovich@opuscapita.com>
@jakubszewczyk, some of your stuff didn't work. So, I added some modifications to |
@kvolkovich-sc That's right, thanks for the tip. |
This PR could add the ability to add own handlers to resource items events. For example if you want to open your own image viewer by double clicking on image file in FileManager it would be impossible. You could only use onSelectionChange, which fires on single click.
Release notes
Add the ability to call click, doubleClick and rightClick events handles through props, so that the user can call own actions on those events.