Remove log directory creation #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-junot
added a commit
that referenced
this pull request
Oct 9, 2020
* Add non-root user for running uwsgi in Dockerfile * Fix PermissionError due to COPY after chown * Bump flake8 from 3.8.3 to 3.8.4 Bumps [flake8](https://gitlab.com/pycqa/flake8) from 3.8.3 to 3.8.4. - [Release notes](https://gitlab.com/pycqa/flake8/tags) - [Commits](https://gitlab.com/pycqa/flake8/compare/3.8.3...3.8.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Bump pytest from 6.1.0 to 6.1.1 Bumps [pytest](https://github.com/pytest-dev/pytest) from 6.1.0 to 6.1.1. - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/master/CHANGELOG.rst) - [Commits](pytest-dev/pytest@6.1.0...6.1.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Remove log directory creation (#391) * Remove log directory creation * Remove unused import * Remove rate limiting for now * Fix volume permission overwrite This problem seems to be already known in docker/compose#3270 (comment) * Fix duplicate root mkdir * Disable pytest test caching See pytest-dev/pytest#3557 * Add blank coverage file * Added extra overriding of permissions command in CI config * Added user UID * Clean Dockerfile and revert pytest.ini Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Aaron Suarez <aaron.j.suarez1@gmail.com> Co-authored-by: Abdelrahman Kandil <abdelrahmankandil@hotmail.com> Co-authored-by: Aaron Suarez <aaron-suarez@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't open a new issue because it didn't seem necessary, but #388 is blocked by the log directory creation.
I've gone though the code, checked where it was created and removed the related lines.