Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ERC20 _setTokenURI #1618

Merged
merged 5 commits into from
Jan 25, 2019
Merged

Add ERC20 _setTokenURI #1618

merged 5 commits into from
Jan 25, 2019

Conversation

nventuro
Copy link
Contributor

I also renamed the contract, since it used to be spit in two for no apparent reason.

Fixes #1612

@nventuro nventuro added feature New contracts, functions, or helpers. contracts Smart contract code. labels Jan 22, 2019
@nventuro nventuro added this to the v2.2 milestone Jan 22, 2019
@nventuro nventuro requested a review from frangio January 22, 2019 21:02
frangio
frangio requested changes Jan 22, 2019
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

contracts/drafts/ERC1046/ERC20Metadata.sol Show resolved Hide resolved
@frangio frangio merged commit 8dd92fd into OpenZeppelin:master Jan 25, 2019
@nventuro nventuro deleted the erc20-internal-token-uri branch February 20, 2019 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
contracts Smart contract code. feature New contracts, functions, or helpers.
Projects
None yet
Milestone
v2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@nventuro @frangio