Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise default secret size to 128 #8

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Conversation

termermc
Copy link
Contributor

@termermc termermc commented Sep 29, 2023

04:50 AM <termer> Elegantbeef, Gitea uses a 64 char TOTP secret
04:50 AM <termer> I'm thinking Nim OTP should have 64 as its default, not 32
04:51 AM <FromDiscord> <Elegantbeef> PR's welcome
04:51 AM <termer> All right
04:51 AM <FromDiscord> <Elegantbeef> Fuck it do 128 by default 😛

@ba0f3
Copy link
Collaborator

ba0f3 commented Sep 29, 2023

I'm not sure what value is the best :(

@beef331
Copy link
Contributor

beef331 commented Oct 2, 2023

My uneducated view is that 128 bytes is only the size of array[16, int64] it's still relatively small. Remember this is just a default value. If someone wants they can always lower it. Ideally the size used accepts all common secrets, this size was the major concern I had implementing stackstrings here 😄 I do think 256 or 128 are very fair.

@ba0f3 ba0f3 merged commit 0646aea into OpenSystemsLab:master Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants