Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting a dataset in the webui with child snapshots #47

Open
subzero79 opened this issue May 1, 2018 · 2 comments
Open

Deleting a dataset in the webui with child snapshots #47

subzero79 opened this issue May 1, 2018 · 2 comments

Comments

@subzero79
Copy link
Contributor

The backend throws an error when zfs destroy(delete) pool/dataset exits non-zero if they are child snapshots.

Fix seems trivial, but should we:

  1. add the -r switch to Dataset->destroy(), or

  2. Catch the error if destroy exits non-zero

Comments?

@subzero79
Copy link
Contributor Author

Sorry, forgot to mention. When this happens the mntent is also removed from database, that's the main problem

@artiomn
Copy link
Contributor

artiomn commented Jun 12, 2018

I think if the error in child snapshots that can not be deleted without -r option, user should be asked with a dialog for deletion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants