Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: integrating snapraid-btrfs #40

Open
goofrider opened this issue Jun 15, 2023 · 5 comments
Open

Feature request: integrating snapraid-btrfs #40

goofrider opened this issue Jun 15, 2023 · 5 comments

Comments

@goofrider
Copy link

goofrider commented Jun 15, 2023

Would you consider integrating snapraid-btrfs? It uses btrfs snapshots for snapraid sync, which prevents parity hole problems.

@Max-Sum
Copy link

Max-Sum commented Jun 15, 2023

I don't think we could use the script directly but the idea could be implemented.
Now snapshot support is integrated into OMV core. We can now assume that sharefolder = subvolume and there's no nested subvolume in sharefolder. So basically what we need to do is taking a snapshot for each sharefolder on the data disks before sync.

@goofrider
Copy link
Author

Thank you for your response and glad to hear the idea is being considered. 🙏

@microraptor
Copy link

microraptor commented Aug 20, 2023

There was work done integrating the script here: https://github.com/CCraigen/openmediavault-snapraid-btrfs

However, as you said integrating the functionality more natively into OMV without the script is most likely the best way. This plugin with BTRFS would then be quite unique in solving usability issues other parity systems have.

@ryecoaaron
Copy link
Member

ryecoaaron commented Aug 20, 2023

We can now assume that sharefolder = subvolume and there's no nested subvolume in sharefolder. So basically what we need to do is taking a snapshot for each sharefolder on the data disks before sync.

There are a few problems with this.

  • Other filesystems are still supported by the plugin
  • The shared folder on btrfs was created with the new OMV btrfs support.
  • You only use btrfs
  • You only have data in shared folders since the plugin currently works at the disk level not sharedfolder level

There was work done integrating the script here:

I looked at that but it is very outdated now. It basically just creates a snapper config file and swaps the snapraid command out for snapraid-btrfs. Since snapper would not be used in this proposal, there isn't much work that can be used.

as you said integrating the functionality more natively into OMV without the script is most likely the best way.

I agree but it would be a huge amount of work especially to keep working with other filesystems and the majority of OMV snapraid uses are not using btrfs.

It probably should be a different plugin that works at the sharedfolder level and only supports btrfs.

@microraptor
Copy link

It probably should be a different plugin that works at the sharedfolder level and only supports btrfs.

That does seem to make a lot of sense.

Just for clarification to other readers: A separate BTRFS plugin on shared-folder level (instead of disk level) is necessary, because the new shared folders are automatically subvolumes (which enables the snapshot feature). SnapRAID excludes any nested subvolumes and therefore all shared folders on BTRFS, which were created the new way. See the first posts of this discussion: https://forum.openmediavault.org/index.php?thread/47536-is-snapraid-compatable-with-new-btrfs-snapshots/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants