Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading log message for lost runs #1757

Closed
taylordowns2000 opened this issue Feb 15, 2024 · 1 comment · Fixed by #1858
Closed

Misleading log message for lost runs #1757

taylordowns2000 opened this issue Feb 15, 2024 · 1 comment · Fixed by #1858
Assignees

Comments

@taylordowns2000
Copy link
Member

taylordowns2000 commented Feb 15, 2024

The log message displayed for a run that has been lost is misleading. Rather than showing "Nothing yet" we should have a separate log, input, and output message for when a run is in one of the :final_states.

Image

Desired wording:

  1. Logs: "No logs were received for this run."
  2. Input: If no other data_retention related messages are shown, then: "No input state could be saved for this run."
  3. Output: If no other data_retention related messages are shown, then: "No output state could be saved for this run."

Note that we've now got a lot of conditionals around what to display for dataclips. How do we know that an output dataclip was not saved because of a crash, instead of not being saved because of a customers input/output data storage policy?

@taylordowns2000
Copy link
Member Author

taylordowns2000 commented Feb 28, 2024

@elias-ba , we are trying to re-articulate this together: 80/20...

  • For logs there is a fallback which is currently "nothing yet". We want to make that fallback conditional on the state: if the state is in final_states make the fallback say "No logs were received for this run." if not, make the fallback say "nothing yet..."
  • For input and output, there are currently 3 states (real JSON data, dataclip wiped, nothing yet...) and similar to logs, we want to adjust the fallback state from always being "nothing yet" to being "No ${input/output} state could be saved for this run." if the run state is in final_states.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants