Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remaining warnings, enable "warnings as errors" #1642

Closed
taylordowns2000 opened this issue Jan 18, 2024 · 0 comments · Fixed by #1541
Closed

Fix remaining warnings, enable "warnings as errors" #1642

taylordowns2000 opened this issue Jan 18, 2024 · 0 comments · Fixed by #1541
Assignees
@jyeshe

Comments

@taylordowns2000
Copy link
Member

image
@taylordowns2000 taylordowns2000 mentioned this issue Jan 18, 2024
Merged
4 tasks
@jyeshe jyeshe self-assigned this Jan 19, 2024
@jyeshe jyeshe mentioned this issue Jan 19, 2024
Merged
4 tasks
taylordowns2000 added a commit that referenced this issue Jan 19, 2024
@taylordowns2000
restore warnings_as_errors to fix #1642
b753894
stuartc pushed a commit that referenced this issue Jan 24, 2024
@taylordowns2000 @jyeshe
Replace use of Application.get_env in Endpoint module (#1541)
f559bf5 
* use Application.compile_env in endpoint module, dont set default size in two different places
* Activate Replug
* Restore warnings_as_errors to fix #1642

---------

Co-authored-by: Rogerio Pontual <rppontual@gmail.com>
Co-authored-by: Rogerio Pontual <44991200+jyeshe@users.noreply.github.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jyeshe jyeshe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace use of Application.get_env in Endpoint module OpenFn/lightning
2 participants
@taylordowns2000 @jyeshe