Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to Docker #993

Merged
merged 20 commits into from
Dec 22, 2023
Merged

Add tests to Docker #993

merged 20 commits into from
Dec 22, 2023

Conversation

hamelsmu
Copy link
Collaborator

@hamelsmu hamelsmu commented Dec 21, 2023 •
edited
Loading

This runs unit tests in Docker images to hopefully catch issues like those seen in #985 We could add the e2e test soon when you get more compute

This closes #985

@hamelsmu hamelsmu mentioned this pull request Dec 21, 2023
Closed
winglian
winglian approved these changes Dec 22, 2023
View reviewed changes
Copy link
Collaborator

@winglian winglian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I think we'll just need to keep an eye on this action after it gets merged and verify the tags look correct.

@hamelsmu hamelsmu merged commit 2e61dc3 into main Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winglian winglian winglian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker image appear to be broken due to flash_atten
2 participants
@hamelsmu @winglian