Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: bf16 support for inference #981

Merged
merged 2 commits into from
Dec 29, 2023
Merged

Fix: bf16 support for inference #981

merged 2 commits into from
Dec 29, 2023

Conversation

taziksh
Copy link
Contributor

@taziksh taziksh commented Dec 19, 2023

Inference with bf16 is currently broken. I found that this simple change fixes the issue. Credits to @mathiasesn for the initial discovery.

NanoCode012
NanoCode012 reviewed Dec 22, 2023
View reviewed changes
Copy link
Collaborator

@NanoCode012 NanoCode012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please try this change? We handle the setting of dtype to this variable.

src/axolotl/cli/__init__.py Outdated Show resolved Hide resolved
src/axolotl/cli/__init__.py Outdated Show resolved Hide resolved
@winglian winglian merged commit 3678a6c into axolotl-ai-cloud:main Dec 29, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NanoCode012 NanoCode012 NanoCode012 left review comments

@winglian winglian winglian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@taziksh @winglian @NanoCode012