new evals_per_epoch and saves_per_epoch to make things cleaner #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NanoCode012
reviewed
Dec 12, 2023
NanoCode012
reviewed
Dec 12, 2023
NanoCode012
reviewed
Dec 12, 2023
NanoCode012
reviewed
Dec 12, 2023
| @@ -78,9 +78,13 @@ def normalize_config(cfg): | |||
| cfg.torch_dtype = torch.float32 | |||
|
|
|||
| if cfg.saves_per_epoch: | |||
| cfg.save_steps = 1.0 / (cfg.saves_per_epoch * cfg.num_epochs) | |||
| save_steps = 1.0 / (cfg.saves_per_epoch * cfg.num_epochs) | |||
| if save_steps < 1.0: # prevent saves on every step | |||
There was a problem hiding this comment.
maybe instead of this if save_steps < 1.0:, you should do a check that cfg.saves_per_epoch >= 1
There was a problem hiding this comment.
that doesn't really solve the case I'm solving for. Basically when there is one epoch and one save per epoch, it will lead to save steps being 1, which iirc, causes it to save every step.
winglian
force-pushed
the
saves_per_epoch
branch
from
5467f13
to
2f1ee83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
right now, figuring out what values to put into eval_steps or save_steps is just plain confusing. hoping that simply having
evals_per_epoch: X
saves_per_epoch: X
makes it easier to understand and is probably what people really want.