Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make docker command more robust #861

Merged
merged 2 commits into from
Nov 16, 2023
Merged

make docker command more robust #861

merged 2 commits into from
Nov 16, 2023

Conversation

winglian
Copy link
Collaborator

No description provided.

@NanoCode012
Copy link
Collaborator

NanoCode012 commented Nov 15, 2023

I was told --ipc=host would unlock shared memory size (I didn't double check). I think it would be fine to leave the top one as original to not complicate it.

I'm not so familiar with --privileged.

@casper-hansen
Copy link
Collaborator

LGTM!

@winglian winglian merged commit 8a8d1c4 into main Nov 16, 2023
@winglian winglian deleted the docker-args-readme branch November 16, 2023 04:03
mkeoliya pushed a commit to mkeoliya/axolotl that referenced this pull request Dec 15, 2023
* make docker command more robust

* update readme with more info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants