Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various bugfixes #856

Merged
merged 4 commits into from
Nov 15, 2023
Merged

various bugfixes #856

merged 4 commits into from
Nov 15, 2023

Conversation

winglian
Copy link
Collaborator

@winglian winglian commented Nov 15, 2023

use latest tinyllama release
check if val_set_size is empty first
update sdp and xformers llama patches for updated upstream transformers
fix system prompt when no input
calculate total and total supervised tokens even when not sample packing

use latest tinyllama release
check if val_set_size is empty first
update sdp and xformers llama patches for updated upstream transformers
fix system prompt when no input
calculate total and total supervised tokens even when not sample packing
@NanoCode012
Copy link
Collaborator

NanoCode012 commented Nov 15, 2023

Hey, I recall our conversation about some ValueError: Expected len>=0. Was that issue fixed? If not, can it be combined here.

@winglian
Copy link
Collaborator Author

Hey, I recall our conversation about some ValueError: Expected len>=0. Was that issue fixed? If not, can it be combined here.

just pushed a fix for that too. thanks!

Copy link
Collaborator

@NanoCode012 NanoCode012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the kwargs is also needed on every other patch, but this looks good to me!

@winglian winglian merged commit 1470650 into main Nov 15, 2023
4 checks passed
@winglian winglian deleted the bugfixes001-20231115 branch November 15, 2023 17:23
mkeoliya pushed a commit to mkeoliya/axolotl that referenced this pull request Dec 15, 2023
* various bugfixes

use latest tinyllama release
check if val_set_size is empty first
update sdp and xformers llama patches for updated upstream transformers
fix system prompt when no input
calculate total and total supervised tokens even when not sample packing

* add fix for when eval size is estimated to be too small

* should be len 1 for dataset length

* add catchall kwargs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants