Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include the suffix modified string in ascii art #852

Merged
merged 1 commit into from
Nov 15, 2023
Merged

include the suffix modified string in ascii art #852

merged 1 commit into from
Nov 15, 2023

Conversation

fpreiss
Copy link
Contributor

@fpreiss fpreiss commented Nov 15, 2023

Previously the suffix was applied to modify the ascii_text string. ascii_text was however not added to the actual print statement.

winglian
winglian approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@winglian winglian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks!

@winglian winglian merged commit 614cff4 into axolotl-ai-cloud:main Nov 15, 2023
4 checks passed
mkeoliya pushed a commit to mkeoliya/axolotl that referenced this pull request Dec 15, 2023
@fpreiss
include the suffix modified string in ascii art (axolotl-ai-cloud#852)
aaf8fbd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winglian winglian winglian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fpreiss @winglian