improve handling of the prepared ds path and other cfg defaults #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't this revert the no cache behavior when prepared dataset config is missing? |
|
it writes the cache, it just doesn't use it. Which I think is safer in most cases, especially if you're explicitly running prepare_ds_only. Like if you're running that command, and not caching the dataset, it serves no purpose, since that's the expectation of running prepare. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defaults to saving the prepared dataset, even if it's not going to be used unless explicitly called
warns in red when calling prepare_ds_only without a prepared dataset path set
disable sample packing when doing inference