minor tweaks to simplify #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NanoCode012
reviewed
Sep 18, 2023
| @@ -489,6 +489,8 @@ def calculate_total_num_steps(cfg, train_dataset, tokenizer): | |||
| data_loader_len = data_loader.len_w_stats() | |||
| actual_eff = data_loader.efficiency() | |||
| LOG.info(f"data_loader_len: {data_loader_len}") | |||
| # FIXME: is there a bug here somewhere? the total num steps depends | |||
| # on the agreed on value for sample_packing_eff_est | |||
There was a problem hiding this comment.
what does this mean? Do you mean the total num steps should be affected by sample efficiency or some other var?
There was a problem hiding this comment.
exactly. because if the various processes have different calculations, we choose the max value to find the smallest steps that they all share. It doesn't seem to be a major issue atm, but should get addressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
don't debug the attention mask value since that is almost always exclusively
1for all cases.simplify config by not asking users to update the total_num_tokens and sample_packing_eff_est since that computation has been optimized and the optimization to set that ahead of time can cause headaches