improve how we setup eval/save strategies and steps #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NanoCode012
approved these changes
Sep 11, 2023
| # save_steps implies save_strategy of steps | ||
| training_arguments_kwargs["save_strategy"] = "steps" | ||
| training_arguments_kwargs["save_steps"] = cfg.save_steps | ||
| elif cfg.save_strategy: |
There was a problem hiding this comment.
One side effect would be that: individuals who depend on save_strategy: epoch/no and forget to remove save_step would get a different result. However, this change is good as it's more logical.
Closed
mkeoliya
pushed a commit
to mkeoliya/axolotl
that referenced
this pull request
Dec 15, 2023
…#547) * setup save end eval strategies to be consistent with trainer logic * add comments * better eval handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.