chore(callback): Remove old peft saving code #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmm1
approved these changes
Aug 30, 2023
|
Per winglian's comment in Discord, relora might need this code. I think I need some confirmation what relora usually saves at as I haven't trained one before. And if it's necessary for only relora, we can change the condition for only then. |
|
Seems like relora already saves its own adapter_model 
|
NanoCode012
force-pushed
the
chore/remove_peftcallback
branch
from
d1c9683
to
1e2bd08
Compare
|
Rebased! |
NanoCode012
force-pushed
the
chore/remove_peftcallback
branch
from
1e2bd08
to
8abfbed
Compare
mkeoliya
pushed a commit
to mkeoliya/axolotl
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, peft does not save the adapter, hence we needed this code. After peft updated a while back, this callback unnecessarily saves the adapter another time.
We can now remove it.