Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fused-dense-lib from requirements.txt #1087

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Conversation

casper-hansen
Copy link
Collaborator

This requirement can already be installed with pip install -e .[fused-dense-lib] and is the only requirement that prevents us from installing axolotl without a GPU.

Copy link
Collaborator

@winglian winglian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is pip install -e . trying to install fused-dense-lib? it should get filtered out similarly to flash-attn here: https://github.com/OpenAccess-AI-Collective/axolotl/blob/main/setup.py#L14-L24

@casper-hansen
Copy link
Collaborator Author

That might be right, but something was installing this dependency in axolotl without me specifying it and thought this might be the issue. Given that it's filtered out anyway, why is it in requirements when it's an extra?

@winglian
Copy link
Collaborator

haha, that's a totally valid question! I keep it in requirements.txt so anyone could reasonably see all the potential dependencies. Like we currently keep flash-attn in there as well. I'm not staunch in my position that we should keep it in there, so if you feel that ergonomically we should remove it, I'm fine with that. Ultimately I'd like to move to something like poetry or have it in something like pyproject.toml

@casper-hansen casper-hansen merged commit 91502b9 into main Jan 10, 2024
6 checks passed
@winglian winglian deleted the req_remove_dep branch January 23, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants