Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Up LorA Merge #1044

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Clean Up LorA Merge #1044

merged 1 commit into from
Jan 5, 2024

Conversation

hamelsmu
Copy link
Collaborator

@hamelsmu hamelsmu commented Jan 5, 2024

This PR does the following things:

  1. Added some docs as suggested by @NanoCode012
  2. Makes the merge do the sensible default thing and read from your config's output_dir if --lora_model_dir is not provided.

@hamelsmu hamelsmu merged commit 63fb3eb into main Jan 5, 2024
6 checks passed
@winglian winglian deleted the clean-up-merge branch January 23, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants