Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] delete unused cfg value lora_out_dir #1029

Merged
merged 3 commits into from
Jan 3, 2024
Merged

[Docs] delete unused cfg value lora_out_dir #1029

merged 3 commits into from
Jan 3, 2024

Conversation

hamelsmu
Copy link
Collaborator

@hamelsmu hamelsmu commented Jan 2, 2024

lora_out_dir is not an active config value output_dir is the config value to use. I confirmed this with @winglian

I also tested this and it doesn't appear that this config value does anything.

Copy link
Collaborator

@NanoCode012 NanoCode012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

README.md Outdated Show resolved Hide resolved
Co-authored-by: NanoCode012 <kevinvong@rocketmail.com>
@hamelsmu hamelsmu merged commit a3e8783 into main Jan 3, 2024
@winglian winglian deleted the fix-docs-config branch January 23, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants