Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change title for the actor page to an H1 element #118

Open
evanp opened this issue Apr 4, 2023 · 4 comments
Open

Change title for the actor page to an H1 element #118

evanp opened this issue Apr 4, 2023 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers javascript Pull requests that update Javascript code

Comments

@evanp
Copy link
Contributor

evanp commented Apr 4, 2023 •
edited
Loading

Search engine spiders look for an H1 element on a page to define the topic of the page.

We should change the span element for the actor title to an h1.
@evanp evanp added enhancement New feature or request good first issue Good for newcomers javascript Pull requests that update Javascript code labels Apr 4, 2023
@evanp
Copy link
Contributor Author

evanp commented Apr 4, 2023

Screenshot 2023-04-04 at 10 42 37 AM

@The5cheduler
Copy link

I would like to contribute to this, Could someone please guide which files I need to work with?
Thank you.

@evanp
Copy link
Contributor Author

evanp commented Apr 20, 2023

@The5cheduler the line is here:

https://github.com/Open-Earth-Foundation/OpenClimate/blob/develop/ui/src/components/review/review.page.tsx#L211

@The5cheduler
Copy link

Sorry, I got a little busy, and could not update the issue.
I have worked on this issue locally, Please assign me so, I can make PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@evanp @The5cheduler