Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add __repr__ and model_list in ModelCreator #123

Merged
merged 5 commits into from
Jan 22, 2022
Merged

Conversation

rentainhe
Copy link
Contributor

@rentainhe rentainhe commented Jan 21, 2022

TODO

  • Add __repr__ and __str__ in ModelCreator for specific case
  • Support ModelCreator.model_list() func
  • Update ChangeLog

@rentainhe rentainhe requested a review from Ldpe2G January 21, 2022 16:38
@rentainhe rentainhe changed the title add __repr__ in Creator add __repr__ and model_list in Creator Jan 21, 2022
@rentainhe rentainhe changed the title add __repr__ and model_list in Creator add __repr__ and model_list in ModelCreator Jan 21, 2022
@@ -84,3 +88,30 @@ def model_table(filter="", pretrained=False, **kwargs):
table_items, headers=table_headers, tablefmt="fancy_grid", **kwargs
)
return table

@staticmethod
def model_list(filter="", pretrained=False, **kwargs):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

把文档加上吧,描述一下这个函数功能是什么

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

把文档加上吧,描述一下这个函数功能是什么

写到docs里了,在这个PR下 #124

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的

@Ldpe2G Ldpe2G merged commit d870085 into main Jan 22, 2022
@Ldpe2G Ldpe2G deleted the dev_refine_creator branch January 22, 2022 04:48
@rentainhe rentainhe self-assigned this Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants