support var op convert #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
…neflow_convert into dev_support_var_op_convert
BBuf
reviewed
Sep 10, 2022
| "Mul", [sub_v, sub_v], op_name_scope=node.name, name="mul", dtypes=dtypes | ||
| ) | ||
| sqr_sub = mul_node.output_tensor_names[0] | ||
| if unbiased == 1: |
There was a problem hiding this comment.
这个correction是不是等价于unbiased，这里是否需要correction这个变量？
There was a problem hiding this comment.
是的，unbiased=True等价于correction==1（correction去掉或保留都行
BBuf
reviewed
Sep 10, 2022
| input_shape = ctx.get_shape(node.input_tensor_names[0]) | ||
| keepdim_mean = 0 if origin_dim is None else keepdim | ||
| correction = 0 | ||
|
|
There was a problem hiding this comment.
空行多了，可以refine一下格式，后面有空我在ci加一个格式化。
Flowingsun007
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
BBuf
reviewed
Sep 10, 2022
| return out | ||
|
|
||
|
|
||
| def test_math_ops(): |
There was a problem hiding this comment.
要么把这个测试放到test_math_ops.py里，要么这里改一下名别叫MathOpxxx
Flowingsun007
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
BBuf
approved these changes
Sep 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.