Upgrade to OmniSharp version 1.38.0 #4961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeRobich
commented
Dec 16, 2021
| { platformInfo: new PlatformInformation('linux', 'arm64'), id: "linux-arm64" }, | ||
| { platformInfo: new PlatformInformation('darwin', 'x86_64'), id: "darwin-x64" }, | ||
| { platformInfo: new PlatformInformation('darwin', 'arm64'), id: "darwin-arm64" }, | ||
| { platformInfo: new PlatformInformation('win32', 'x86_64'), id: "win32-x64", isFramework: true }, |
There was a problem hiding this comment.
Ensure we are only packaging the Full Framework version of O#. Packaging both in addition to our debugger and razor lsp may push our size over the marketplace limit. We should transition in a couple releases to packaging the SDK build of O# and enabling it by default.
JoeRobich
commented
Dec 16, 2021
| eventStream.post(new InstallationFailure(installationStage, new Error("A release package of OmniSharp does not exist for this platform. Set \"omnisharp.path\" to \"latest\" in Settings to use an experimental build."))); | ||
| continue; | ||
| if (pkg.id === "OmniSharp") { | ||
| if (pkg.isFramework !== useFramework) { |
There was a problem hiding this comment.
Ensure we are only looking at OmniSharp dependencies that match our framework option.
JoeRobich
commented
Dec 16, 2021
| "workspaceContains:**/*.slnf", | ||
| "workspaceContains:**/*.csx", | ||
| "workspaceContains:**/*.cake" | ||
| "workspaceContains:**/*.{csproj,sln,slnf,csx,cake}" |
There was a problem hiding this comment.
Simplify our search for files to activate against.
JoeRobich
commented
Dec 16, 2021
| "fallbackUrl": null, | ||
| "installPath": null, | ||
| "url": "https://roslynomnisharp.blob.core.windows.net/releases/1.38.0/omnisharp-win-x86-net6.0-1.38.0.zip", | ||
| "installPath": ".omnisharp/1.38.0-net6.0", |
There was a problem hiding this comment.
This install path matches the path we use when downloading latest package and avoids conflicting with full framework installs.
filipw
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.