Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests #109

Open
stefanhenneking opened this issue Mar 16, 2023 · 5 comments
Open

Tests #109

stefanhenneking opened this issue Mar 16, 2023 · 5 comments
Assignees
Labels
testing Unit tests, etc

Comments

@stefanhenneking
Copy link
Contributor

stefanhenneking commented Mar 16, 2023

Add more unit and integration tests to hp3D.

Related PRs:

@jedbrown
Copy link

It would be wonderful to hook these tests up to GitHub actions (or other continuous integration).

@stefanhenneking
Copy link
Contributor Author

Thanks for the suggestion, @jedbrown. It's on our TODO list but so far no one's worked on it (personally I don't have much experience setting up GitHub actions for packages with lots of dependencies). I've now opened #155 to keep track of any CI efforts specifically.

@jedbrown
Copy link

It's likely to come up in review. Peter works on deal.II, which uses the approach of creating a Docker image with all dependencies and using that from Actions. https://github.com/dealii/dealii/blob/master/.github/workflows/linux.yml#L40
An alternative is to install dependencies using a package manager (such as apt install) from the script.

@stefanhenneking
Copy link
Contributor Author

I figured that installing dependencies from script we'd probably run out of free minutes on GitHub fairly quickly. But I'll look into the option with the Docker image - thanks for the suggestion.

@stefanhenneking
Copy link
Contributor Author

Added CI in #159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Unit tests, etc
Projects
None yet
Development

No branches or pull requests

4 participants