Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lodestar warning logs added to errors page #242

Merged
merged 7 commits into from
Nov 11, 2023

Conversation

maeliosakyne
Copy link
Contributor

Summary

Lodestar warning logs added to errors page under FAQ section

Details

warnings added

ticket:
issue #233

@maeliosakyne maeliosakyne linked an issue Aug 10, 2023 that may be closed by this pull request
1 task
@netlify
Copy link

netlify bot commented Aug 10, 2023

Deploy Preview for obol-docs ready!

Name Link
🔨 Latest commit de9b82d
🔍 Latest deploy log https://app.netlify.com/sites/obol-docs/deploys/654f1f28be17520008eca301
😎 Deploy Preview https://deploy-preview-242--obol-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@thomasheremans thomasheremans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to keep the errors generic and without parameters, in this case both errors are the same, only refer to different slots/blocks. Only one is needed.

docs/int/faq/errors.mdx Outdated Show resolved Hide resolved
docs/int/faq/errors.mdx Outdated Show resolved Hide resolved
maeliosakyne and others added 2 commits August 16, 2023 15:34
removed second lodestar warning

Co-authored-by: Thomas H <107747791+thomasheremans@users.noreply.github.com>
Co-authored-by: Thomas H <107747791+thomasheremans@users.noreply.github.com>
docs/int/faq/errors.mdx Outdated Show resolved Hide resolved
@maeliosakyne maeliosakyne requested review from OisinKyne and dB2510 and removed request for thomasheremans August 23, 2023 11:37
Copy link
Contributor

@dB2510 dB2510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasheremans thomasheremans merged commit a7fe7fe into main Nov 11, 2023
5 checks passed
@OisinKyne OisinKyne deleted the Maeliosa/Lodestar-warning-logs branch November 30, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add expected lodestar warning in FAQs
5 participants