Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lodestar validator client #23

Closed
Tracked by #66
corverroos opened this issue Apr 11, 2022 · 5 comments
Closed
Tracked by #66

Add lodestar validator client #23

corverroos opened this issue Apr 11, 2022 · 5 comments
Labels
protocol Protocol Team tickets

Comments

@corverroos
Copy link
Contributor

Problem to solve

Charon states it supports Lodestar validator client. But this hasn't been tested or confirmed yet. This repo also only had teku and lighthouse.

Proposed solution:

  • Add lodestar as VC for node2.
  • First prize is implemeting it the same as teku (without a folder or run script), just a docker-compose service.
  • Remember to configure network as auto, since charon can connect to prater/gnosis/kiln/simnet/devnet.
  • Remember to load the keys on startup.
  • If this is not trival, like lighthouse, a folder and run script can be added.
  • Try to keep everything to the absolute minimum
@dB2510
Copy link
Collaborator

dB2510 commented May 4, 2022

This issue is currently blocked by ObolNetwork/charon#473

@OisinKyne
Copy link
Contributor

Custom preset requirements for simnet are now out of scope for this template repo. We can move forward with lodestar support without it (and without custom dockerfiles/run scripts 🤞 ) . Pulling out of parking lot.

@dB2510
Copy link
Collaborator

dB2510 commented Nov 9, 2022

Current status of this issue:

  • Lodestar uses an optimization to use a single attestation data for all committees is a probable blocker ito supporting it.
  • The beacon spec provides NO guarantees that attestation datas for different committees MUST be identical.
  • In the event that charon stores different attestation datas in the dutydb (for the same slot), then lodestar will basically attest with a SINGLE attestation data while other VCs will attest using the different datas, resulting in aggregation failure.
  • It might be that that in 99% of the time, all attestation datas are actually the same for different committees, it is however only an accidental implementation phenomenon which might change at anypoint due to changes in implementation or race conditions in the code.
  • We are going to monitor whether we can detect inconsistent attestation data for different committees, which will prove that we cannot support lodestar.
  • If we cannot detect inconsistencies, then we are in a tough spot, since we can provisionally support lodestar with the caveat that attestation might fail at any point.

@thomasheremans thomasheremans added the protocol Protocol Team tickets label Jan 23, 2023
@dB2510
Copy link
Collaborator

dB2510 commented Feb 1, 2023

To track with lodestar repo: ChainSafe/lodestar#4687

@OisinKyne
Copy link
Contributor

Can we close this when lodestar v1.10 comes out? Or can we close it already even?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol Protocol Team tickets
Projects
None yet
Development

No branches or pull requests

5 participants