Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

II.1.6.1 Xpath is missing #302

Closed
muricna opened this issue Jan 20, 2023 · 1 comment
Closed

II.1.6.1 Xpath is missing #302

muricna opened this issue Jan 20, 2023 · 1 comment
Labels
type: bug Something implemented incorrectly in a release.

Comments

@muricna
Copy link

muricna commented Jan 20, 2023

Xpath is missing and a reference made in the notes to the remarks page in F22. See also issue 191 for similar but different problem in F25. Other forms should be checked.

@muricna muricna added the type: bug Something implemented incorrectly in a release. label Jan 20, 2023
@csnyulas csnyulas added the act: for closing it can be closed but an additional confirmation is needed label Mar 6, 2023
@csnyulas
Copy link
Contributor

csnyulas commented Mar 6, 2023

We included a Note, to reference the "Mapping Remarks" sheet, where we explain why we don't have a mapping for this field (CM version 6.8.0).

We are not providing an XPATH in the "Rules" sheet, as not to generate unnecessary SPARQL queries (or to avoid failure of generating "empty" SPARQL queries). Despite of this, it is important to mention this field in the "Rules" sheet, especially for forms F21, F22 and F23 (which is what we did before), because in those forms this field has several sub-fields, as well (II.1.6.1.1, II.1.6.1.2, II.1.6.1.3), and mentioning II.1.6.1 (although that, itself, is not mapped), it puts the sub-fields in context.

To make the CM consistent among the various forms, we now included field II.1.6.1 (with the appropriate reference note to the "Mapping Remarks" sheet), also for forms F03, F06 and F25.

I will mark this issue "act:for closing", and will close it soon, unless there are objections to the implemented solutions.

@csnyulas csnyulas added this to the 2023-04 milestone Mar 6, 2023
@costezki costezki closed this as completed Jun 9, 2023
@costezki costezki removed the act: for closing it can be closed but an additional confirmation is needed label Jun 9, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something implemented incorrectly in a release.
Projects
None yet
Development

No branches or pull requests

3 participants