This repository has been archived by the owner on Oct 8, 2024. It is now read-only.
Data model #67
Merged
Data model #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for ons-data-map ready! 🔨 Explore the source changes: 7b09d83 🔍 Inspect the deploy log: https://app.netlify.com/sites/ons-data-map/deploys/619b0f1b715fcf00082476fc 😎 Browse the preview: https://deploy-preview-67--ons-data-map.netlify.app |
Signed-off-by: Tom Ridd <twridd@gmail.com>
Signed-off-by: Tom Ridd <twridd@gmail.com>
Signed-off-by: Tom Ridd <twridd@gmail.com>
Signed-off-by: Tom Ridd <twridd@gmail.com>
Signed-off-by: Tom Ridd <twridd@gmail.com>
Signed-off-by: Tom Ridd <twridd@gmail.com>
Signed-off-by: Tom Ridd <twridd@gmail.com>
Signed-off-by: Tom Ridd <twridd@gmail.com>
Signed-off-by: Tom Ridd <twridd@gmail.com>
Signed-off-by: Tom Ridd <twridd@gmail.com>
thomasridd
force-pushed
the
feature/data-model
branch
from
b1450e0
to
11d6592
Compare
Signed-off-by: Tom Ridd <twridd@gmail.com>
Signed-off-by: Tom Ridd <twridd@gmail.com>
thomasridd
requested review from
designorant,
patrickjfl,
VivianAllen and
vmilitaru
designorant
approved these changes
Nov 23, 2021
| code={`<script> | ||
| let radioValue = "none"; | ||
| </script> | ||
| code={`<script ✂prettier:content✂="CiAgICAgIGxldCByYWRpb1ZhbHVlID0gIm5vbmUiOwogICA=">{}</script> |
There was a problem hiding this comment.
This is a bug in Prettier's Svelte Plugin. We've removed that <script/> tag from there as a temporary workaround.
| # Map | ||
|
|
||
| The map has been refactored to make it easier to use. There is no html in the MapComponent.svelte components which makes | ||
| this relaltively easy |
There was a problem hiding this comment.
l 😅
Wouldn't bother pointing this out but wanted a space to say this doc is great!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is massive but puts in place a data model and map functionality.
I'm sure there are features that are missing but if we can pay some quick attention and use our components we will be able to put out full user journeys this sprint