Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][REF][l10n_br_nfe_spec] monkey patch is now unused #3240

Draft
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

rvalyi
Copy link
Member

@rvalyi rvalyi commented Jul 26, 2024

olhando pro coverage, parece que os monkey patches que eu tive que fazer para migrar nao estao mais sendo usados agora que eu simplifiquei o modelo de herança dos mixins spec:
https://app.codecov.io/gh/OCA/l10n-brazil/blob/16.0/l10n_br_nfe_spec%2Ftests%2Ftest_nfe_import.py
#2880

@rvalyi rvalyi changed the title [REF][l10n_br_nfe_spec] monkey patch is now unused [16.0][REF][l10n_br_nfe_spec] monkey patch is now unused Jul 26, 2024
@rvalyi rvalyi force-pushed the 16.0-make-nfe-spec-great-again branch from fe8dbcf to 21c6a47 Compare July 26, 2024 23:35
@rvalyi rvalyi force-pushed the 16.0-make-nfe-spec-great-again branch from 21c6a47 to beeac58 Compare July 26, 2024 23:36
@rvalyi
Copy link
Member Author

rvalyi commented Jul 26, 2024

hum vou olhar melhor, parece que ainda usa sim...

   File "/__w/l10n-brazil/l10n-brazil/l10n_br_nfe_spec/tests/test_nfe_import.py", line 111, in match_or_create_m2o_fake
    return comodel.new(new_value)._ids[0]
  File "/opt/odoo/odoo/models.py", line 5757, in new
    record._update_cache(values, validate=False)
  File "/opt/odoo/odoo/models.py", line 5331, in _update_cache
    value = field.convert_to_cache(value, self, validate)
  File "/opt/odoo/odoo/fields.py", line 4132, in convert_to_cache
    if record and not record.id:
AttributeError: 'nfe.40.ide' object has no attribute 'id'

@rvalyi rvalyi marked this pull request as draft July 26, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants