Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for issues encountered with wave/ice coupling #8

Merged

Conversation

mvertens
Copy link
Collaborator

@mvertens mvertens commented Jul 4, 2023

Pull Request Summary

fixes for issues encountered with wave/ice coupling

Description

This PR provides fixes for #7 and #6.

Issue(s) addressed

#7
#6

Commit Message

fixes for issues encountered with wave/ice coupling

Testing

See #6 for description

Copy link

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is technically correct although I suggest a few items that would be improvements IMHO.

model/src/w3fld1md.F90 Outdated Show resolved Hide resolved
model/src/w3fld1md.F90 Show resolved Hide resolved
model/src/w3fld1md.F90 Outdated Show resolved Hide resolved
model/src/w3fld1md.F90 Show resolved Hide resolved
@mvertens mvertens merged commit 5592802 into NorESMhub:noresm Jul 5, 2023
@mvertens mvertens deleted the feature/fixes_for_wave_cice_coupling branch July 5, 2023 07:59
JessicaMeixner-NOAA pushed a commit to JessicaMeixner-NOAA/WW3 that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants