Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added URL support to createClient #658

Conversation

kuwabarahiroshi
Copy link
Contributor

Hi,

I thought it would be useful if we could specify redis server with URL string, like below:

// specify remote redis service.
require('redis').createClient('redis://user:password@redis-service.com:6379/');

// or we can also specify localhost.
require('redis').createClient('//localhost:6379');

This overloaded interface would be useful especially for node apps hosted on heroku, on which redis add-ons is usually provided via ENV variable.

require('redis').createClient(process.env.REDISTOGO_URL);

@kuwabarahiroshi
Copy link
Contributor Author

I remind you guys with indignation! 😃

@tkazec
Copy link

tkazec commented Sep 23, 2014

Yes please! 👍

@jrf0110
Copy link

jrf0110 commented Dec 18, 2014

+1

1 similar comment
@rbvea
Copy link

rbvea commented Jan 14, 2015

+1

@thom4parisot
Copy link

Is there any blocker to merge that PR?

@jonathanong
Copy link

👍

@blainsmith
Copy link
Contributor

Yeah, would love to have this merged!

@jonathanong
Copy link

PING @mranney @brycebaril

@danishin
Copy link

danishin commented Apr 2, 2015

+1

2 similar comments
@mcwhittemore
Copy link

+1

@hunterloftis
Copy link

+1

@angelxmoreno
Copy link

👍 need this

@angelxmoreno
Copy link

wow,just noticed this was posted a while back and it is still open. Any chance we can get some feedback on this so that we are not waiting 10 months on an open ticket?

If the feature is not welcomed then we can post a gist of simple alternative. If it is welcomed then I am sure @kuwabarahiroshi can do a pull+rebase since his PR is now behind master.

@erinishimoticha
Copy link
Contributor

I don't see any problems. If the unix socket test is passing (and it is), this should be merged. I'll merge it if we don't get any negative feedback soon.

@mranney
Copy link
Contributor

mranney commented Jul 12, 2015

Wow, so many +1's. I'm so sorry that I haven't been spending time on this project lately. Please @erinspice make it happen, and if other people want commit access, I'll add you.

@erinishimoticha
Copy link
Contributor

You got it, @mranney!

erinishimoticha added a commit that referenced this pull request Jul 12, 2015
…-to-createClient

added URL support to createClient
@erinishimoticha erinishimoticha merged commit b92a62d into redis:master Jul 12, 2015
@angelxmoreno
Copy link

you guys rock

@erinishimoticha
Copy link
Contributor

Tip your waiters and waitresses! I'm here all night!

@kuwabarahiroshi kuwabarahiroshi deleted the features/add-url-support-to-createClient branch July 13, 2015 08:54
@kuwabarahiroshi
Copy link
Contributor Author

Thanks for merging!
I'm glad that I could contribute such an awesome project.

@thom4parisot
Copy link

\o/ :sparkles: thank you :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.