Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen AVPlayer as default #23

Open
bni opened this issue Apr 19, 2021 · 8 comments
Open

Fullscreen AVPlayer as default #23

bni opened this issue Apr 19, 2021 · 8 comments
Labels
enhancement New feature or request maybe in the future Something that may be done in the future but doesn't have much priority yet

Comments

@bni
Copy link

bni commented Apr 19, 2021

The multiple views stuff is extremely cool, but most people will want to just view the main broadcast feed I think.

Certainly the case for me, I was quite confused at first why there was rounded corners on the video. Also its inconvenient to navigate to the far right to enter fullscreen, each time. Make that button pre-selected?

@ed7789
Copy link

ed7789 commented Apr 19, 2021

The new style player does not seem to allow video scrubbing.

When I want to pick up the session where I left off during the live session, I somehow entered the tvOS player and then only I could scrub to the point I wanted.

@NoahFetz
Copy link
Owner

Ok so if you want to just watch the main feed you do this once at the start of the race and someone who uses the multi viewer probably wants to switch a lot between views so let's say he uses the close channel button 10 times per race compared to once at the beginning. So I'm gonna leave the button there for now unless I get more people suggesting that, since it's also more in line with other players like QuickTime/YouTube/Default macOS Player in a Browser etc, which all have the fullscreen button on the right.

@NoahFetz
Copy link
Owner

Yes right now you can't scrub directly but as you said you can fullscreen one player and scrub to your desired location. I wanted to add a scrubber but didn't have the time to do so and also it's pretty difficult to get it right since the tvOS focus engine is a b*tch.

@anthonymckay
Copy link

@NoahFetz I think part of the problem is that the "fullscreen" button isn't a very intuitive/obvious solution. If I have only the main screen up, it's already fullscreen so a user isn't likely to go looking for a "fullscreen" button in order to access video scrubbing. I only figured it out by finding this issue thread.

@ed7789
Copy link

ed7789 commented Apr 21, 2021

Yes right now you can't scrub directly but as you said you can fullscreen one player and scrub to your desired location. I wanted to add a scrubber but didn't have the time to do so and also it's pretty difficult to get it right since the tvOS focus engine is a b*tch.

I don't know how complicated is the underlying code.

Here's my suggestion: have a preference setting for the old vs current player until all the desired features are implemented. Just my 2 cents.

@NoahFetz
Copy link
Owner

@NoahFetz I think part of the problem is that the "fullscreen" button isn't a very intuitive/obvious solution. If I have only the main screen up, it's already fullscreen so a user isn't likely to go looking for a "fullscreen" button in order to access video scrubbing. I only figured it out by finding this issue thread.

That's why I made a YouTube Tutorial which explains it :)

@NoahFetz
Copy link
Owner

I will add the scrubber next week if I have time so it's redy for the next race weekend

@equals42
Copy link

I sent coffee a couple weeks ago, but thanks again. I found it confusing and user-errorprone to switch and close views. I also got multiple audio feeds overlapping that always started from the beginning of the race but the videos were further into it. I love the idea but was afraid it would mess up my (timeshifted) viewing. Would love a way to sync AppleTV view to iPad so I could watch primary feed on TV and change to other feeds on iPad. (Probably way out of scope for your app.)

@NoahFetz NoahFetz added enhancement New feature or request maybe in the future Something that may be done in the future but doesn't have much priority yet labels May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maybe in the future Something that may be done in the future but doesn't have much priority yet
Projects
None yet
Development

No branches or pull requests

5 participants