Skip to content
This repository has been archived by the owner on Mar 14, 2019. It is now read-only.

Enable usage with Webpack 2 #8

Merged
merged 12 commits into from
Jun 13, 2017
Merged

Enable usage with Webpack 2 #8

merged 12 commits into from
Jun 13, 2017

Conversation

avdgaag
Copy link
Contributor

@avdgaag avdgaag commented Apr 7, 2017

Using the new getOptions ensures we avoid the TypeError for loaderUtils.getLoaderConfig not being a function.

Using the new getOptions ensures we avoid the TypeError for loaderUtils.getLoaderConfig not being a function.
Copy link
Contributor

@ento ento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you try fixing Travis builds? https://travis-ci.org/NoRedInk/elm-assets-loader/builds/219670239

(Thanks for making a PR & sorry not getting around to it sooner)

@ento ento self-assigned this Apr 19, 2017
@TimPerry
Copy link

@avdgaag any chance you could resolve the build issues? Be awesome to get this merged.

@avdgaag
Copy link
Contributor Author

avdgaag commented May 15, 2017

@TimPerry Resolving the build issues would involve upgrading to Webpack 2, triggering more or less a rewrite of all the tests (since they create invalid Webpack 2 configurations) and of course an update of documentation/setup instructions. This is not an enormous amount of work, but it’s not trivial either. I might get around to giving it a shot it over the weekend, but I can’t make any promises.

@avdgaag
Copy link
Contributor Author

avdgaag commented May 22, 2017

I took a stab at fixing this, but I don’t think it’s something I can solve. Updating the Webpack configuration in the tests to be Webpack 2 compatible just led to a whole new rabbit hole of failed tests due to changes in how Webpack 2 works. In my opinion, the entire test suite needs to be rewritten around Webpack 2 and I don’t have the understanding of what we’re trying to test nor of webpack internals to do that 😞

@ento
Copy link
Contributor

ento commented Jun 12, 2017

Taking a stab at fixing tests

@avdgaag
Copy link
Contributor Author

avdgaag commented Jun 12, 2017

Interesting to see this take shape… 😉

@ento
Copy link
Contributor

ento commented Jun 13, 2017

Travis is green for both webpack 1 and 2. Merging!

@ento ento merged commit 605a8b3 into NoRedInk:master Jun 13, 2017
@ento
Copy link
Contributor

ento commented Jun 13, 2017

Published as 0.3.0. Let me know if it doesn't work in any way

@avdgaag
Copy link
Contributor Author

avdgaag commented Jun 14, 2017

Nice! I think the changes in 3e8c664 are what tripped me up. I’ll check if everything still works and report back if it doesn’t.

Thanks for fixing this!

@avdgaag avdgaag deleted the patch-1 branch June 14, 2017 04:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants