-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nerdfonts: make it easier to configure and build #84858
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worldofpeace
suggested changes
Apr 9, 2020
doronbehar
force-pushed
the
improve-nerd-fonts
branch
from
April 9, 2020 23:37
306831c
to
cbac999
Compare
Mic92
reviewed
Apr 10, 2020
Mic92
reviewed
Apr 10, 2020
Mic92
reviewed
Apr 10, 2020
doronbehar
force-pushed
the
improve-nerd-fonts
branch
from
April 10, 2020 08:48
cbac999
to
8ad1e54
Compare
doronbehar
force-pushed
the
improve-nerd-fonts
branch
from
April 10, 2020 10:09
8ad1e54
to
8771aa8
Compare
dtzWill
pushed a commit
to dtzWill/nixpkgs
that referenced
this pull request
Apr 10, 2020
nerdfonts: make it easier to configure and build (cherry picked from commit 87d3217)
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
It takes very long to install nerdfonts and it takes a lot of disk space considering most users' usage of only few specific fonts. With this change, a user can choose the fonts he wishes to install with:
And only the necessary fonts will be downloaded and installed.
This should fix the build for macos and hence supersede #80690 (cc @uosis) .
Things done
pkgs/data/fonts/inconsolata-nerdfont/default.nix
andpkgs/data/fonts/terminus-nerdfonts
as they are redundant now (cc @dmvianna).terminus-nerdfont
andinconsolata-nerdfont
usenerdfonts.override
with the properFonts
attribute, for backwards compatibility.sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)