-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qt5.wrapQtAppsHook: wrap more than just ELF's #65372
Conversation
We should also be able to wrap Python scripts. Note that this also means we can create nested wrappers. While unfortunate, until we have a way to compose wrappers it's the only way.
7d6ab0a didn't actually break this, It probably didn't work even before this since it used to be conditioned on Initially I removed this like you've done here, but I had to restore a similar behavior because of issues I noticed in the plasma5 session Possibly something there shouldn't be wrapped, but since it's added unconditionally when using |
It's not added unconditionally; set |
So I guess the step forward would be to identify in plasma5 what packages provide scripts that shouldn't be wrapped and to set that. |
I expect that most scripts don't need to be wrapped, and I would prefer to use |
This pull request has been mentioned on Nix community. There might be relevant details there: https://discourse.nixos.org/t/wrappers-and-hooks-do-not-invoke-wrapprogram-directly/3551/1 |
Motivation for this change
We should also be able to wrap Python scripts. Note that this also means
we can create nested wrappers. While unfortunate, until we have a way to
compose wrappers it's the only way.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)