Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.scipy: 1.14.0 -> 1.14.1 #336290

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

doronbehar
Copy link
Contributor

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use this opportunity to:

  • nativeBuildInputs -> build-system
  • propagatedBuildInputs -> dependencies
  • remove the with lib; from meta
  • Organize the inputs in this style

Not mandatory, but as we don't touch this derivation too often it might be a good idea.

@doronbehar
Copy link
Contributor Author

Could you use this opportunity to:

* `nativeBuildInputs` -> `build-system`

* `propagatedBuildInputs` -> `dependencies`

* remove the `with lib;` from `meta`

* Organize the inputs in [this style](https://nixos.org/manual/nixpkgs/stable/#buildpythonpackage-function)

Not mandatory, but as we don't touch this derivation too often it might be a good idea.

Good idea. Thanks :) Will merge when CI is mostly green.

Copy link
Contributor Author

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I don't like this diff noise..

@doronbehar
Copy link
Contributor Author

Can be merged when CI is green.

@GaetanLepage
Copy link
Contributor

Thanks for taking the time to double-check the changes :)

@doronbehar
Copy link
Contributor Author

BTW since I noticed you have an affinity to scientific Python packages, maybe you'd like to share your opinion on #327437 ?

@GaetanLepage
Copy link
Contributor

BTW since I noticed you have an affinity to scientific Python packages, maybe you'd like to share your opinion on #327437 ?

Sure, I will have a look later :)

nukeReferences
pythran
pkg-config
wheel
Copy link
Member

@SuperSandro2000 SuperSandro2000 Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 (on the wheel removal)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally would just sort this alphabetically but we can keep it now that you done it :)

@SuperSandro2000 SuperSandro2000 merged commit edee535 into NixOS:staging Aug 28, 2024
28 of 30 checks passed
meson-python
nukeReferences
pythran
pkg-config
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these belong in nativeBuildInputs. Also, numpy is missing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these belong in nativeBuildInputs. Also, numpy is missing.

The existence and not identicallity of both nativeBuildInputs and build-system is new to me. I am still surprised that you require adding to build-system packages that are already part of dependencies. I also don't think enforcing this is worth it. I plan to open a discourse thread about these policies you started to enforce lately, and that we discussed in the related numpy/scipy threads.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants