Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: setup-hook.sh: add genCmakeDefaultFlags() #335682

Open
wants to merge 3 commits into
base: staging
Choose a base branch
from
Open

cmake: setup-hook.sh: add genCmakeDefaultFlags() #335682

wants to merge 3 commits into from

Commits on Aug 21, 2024

  1. cmake: setup-hook.sh: format with shfmt 

    Format with `shfmt -i 4 -w pkgs/by-name/cm/cmake/setup-hook.sh`.

Keeping the code auto-formatted makes refactoring easier.
    @ShamrockLee
    ShamrockLee committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    3ba9aa6 View commit details
    Browse the repository at this point in the history

  2. cmake: setup-hook.sh: collect default flags into cmakeDefaultFlags 

    Collect the default CMake configure flags collected by
cmakeConfigurePhase into a Bash array named cmakeDefaultFlags.
    @ShamrockLee
    ShamrockLee committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    d00607f View commit details
    Browse the repository at this point in the history

  3. cmake: setup-hooks.sh: add genCmakeDefaultFlags 

    Extract the code constructing the cmakeDefaultFlags into a Bash function
genCmakeDefaultFlags.
    @ShamrockLee
    ShamrockLee committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    a3cfdba View commit details
    Browse the repository at this point in the history