nixos/networkd: add [Bridge] section to netdev conf #304117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This setting was missing from netdev. This commit additionally adds a test using the new section, ensuring that STP can be enabled.
ifd3f
force-pushed
the
systemd-networkd-bridge-config
branch
from
af3611a
to
ed854ed
Compare
This was referenced May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This setting was missing from netdev. These parameters are derived from the systemd-networkd manpages.
This commit additionally adds a test that incorporates [Bridge] parameters (ensuring that STP can be enabled, and works correctly).
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenixos/tests/systemd-networkd-bridge.nixand/or package testsor, for functions and "core" functionality, tests in lib/tests or pkgs/testnix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.