Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvmPackages_{12,13,14,15,16,17,18,git}: use common clang #303948

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

RossComputerGuy
Copy link
Member

Description of changes

Partial split from #299807

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@wegank wegank merged commit 6da46d6 into NixOS:master Apr 14, 2024
28 checks passed
@RossComputerGuy RossComputerGuy deleted the feat/llvm-git-commonify-clang branch April 14, 2024 02:55
@pwaller
Copy link
Contributor

pwaller commented Apr 14, 2024

pkgs/development/compilers/llvm/18/clang/default.nix was not removed in this commit. Intentional?

@RossComputerGuy
Copy link
Member Author

@pwaller Might've been missed, I thought I deleted it.

@RossComputerGuy
Copy link
Member Author

@pwaller I'll remove that file during this week's LLVM git update.

@wegank
Copy link
Member

wegank commented Apr 14, 2024

I've made a PR minutes earlier here: #304067

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants